Skip to content

Add settings for color adjustment to demo application#2389

Merged
Keboo merged 3 commits intoMaterialDesignInXAML:masterfrom
FantasyTeddy:master
Aug 2, 2021
Merged

Add settings for color adjustment to demo application#2389
Keboo merged 3 commits intoMaterialDesignInXAML:masterfrom
FantasyTeddy:master

Conversation

@FantasyTeddy
Copy link
Copy Markdown
Contributor

This adds the possibility to enable/disable the automatic color correction in the demo application (resolves #2361).
Additionally it lets the user try out different values for the color adjustment.

Palette

@Keboo
Copy link
Copy Markdown
Member

Keboo commented Aug 2, 2021

This is great work. Thanks you!

@Keboo Keboo added this to the 4.2.0 milestone Aug 2, 2021
@Keboo Keboo added the demo app Items that relate to the demo application label Aug 2, 2021
@Keboo Keboo merged commit 4252ca5 into MaterialDesignInXAML:master Aug 2, 2021
@FantasyTeddy
Copy link
Copy Markdown
Contributor Author

Thank you for fixing the tests, I forgot to run those.
The setting is currently only available under the "Palette" page, should it also be made available for the "Color Tool" page? (Would probably require some refactoring to prevent a lot of copy&paste)

@Keboo
Copy link
Copy Markdown
Member

Keboo commented Aug 2, 2021

No problem, it was a good change and I was wanting to get it in.

It would be nice to also include it on the color tool page, not a big deal either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

demo app Items that relate to the demo application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Color adjustment in light mode with light colors doesn't work properly

2 participants