TabControl: Update IsItemsHost on changes to Visibility rather than IsVisible#3073
Merged
Keboo merged 1 commit intoMaterialDesignInXAML:masterfrom Feb 4, 2023
Merged
Conversation
Keboo
approved these changes
Feb 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3063
Regression introduced in 6be496b.
The original change updated the
Panel.IsItemsHostwhen theboolvalue was changed. This was bound toIsVisible. This PR changes that behavior to bind toVisibilityinstead (which is being set by the triggers).The DP callback did actually fire correctly, but the UI was not appropriately updated. Moving the mouse around and doing "various stuff" could then suddenly make the content appear again. By changing the binding to use
Visibilityinstead, this problem seems to disappear and the control works as expected.