Add TypeScript support#46
Merged
MauriceButler merged 1 commit intoMauriceButler:masterfrom Mar 6, 2023
apstanisic:add-types
Merged
Add TypeScript support#46MauriceButler merged 1 commit intoMauriceButler:masterfrom apstanisic:add-types
MauriceButler merged 1 commit intoMauriceButler:masterfrom
apstanisic:add-types
Conversation
Owner
|
Thanks! Released as v6.2.0 |
This was referenced Aug 19, 2024
This was referenced Aug 27, 2024
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
This was referenced Sep 29, 2024
This was referenced Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added types for Cryptr in
index.ts.Changed package.json to add
typesproperty.I do not think this is a breaking change. Only way this is a breaking change is if user uses TypeScript, but used this package incorrectly, and now his build is failing. But I do not see how that is possible, since this library would've thrown an error already. Anyone who used package properly, user old types from
@types/cryptr, or use only js, this is not a breaking change.But I'll leave that to you.
Closes #45