Merged
Conversation
Maxoscaro
reviewed
Jun 3, 2025
Comment on lines
+1
to
+6
| Анисимов Максим Сергеевич | ||
| Когорта: 22 | ||
| Группа: 2 | ||
| Эпик: Корзина | ||
|
|
||
| Ссылка на доску: [ссылка](https://github.com/users/Maxoscaro/projects/1/views/4) |
Owner
There was a problem hiding this comment.
Спасибо, что мой тоже закинула)
Maxoscaro
reviewed
Jun 3, 2025
Comment on lines
+33
to
+44
| final class Coordinator: NSObject, WKNavigationDelegate { | ||
| var parent: WebViewRepresentable | ||
|
|
||
| init(parent: WebViewRepresentable) { | ||
| self.parent = parent | ||
| } | ||
|
|
||
| func webView(_ webView: WKWebView, didFinish navigation: WKNavigation!) { | ||
| parent.isLoading = false | ||
| } | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
не думаю, что это критично, но я бы вынес класс в отдельный файл, просто для чистоты
Collaborator
Author
There was a problem hiding this comment.
Coordinator, это вспомогательный объект, который связан только с WebViewRepresentable, и он больше нигде не используется.
Maxoscaro
approved these changes
Jun 3, 2025
Owner
Maxoscaro
left a comment
Maxoscaro
left a comment
There was a problem hiding this comment.
Оставил коммент, на твое усмотрение
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Инициализация ServicesAssembly.
Добавила WebView и декомпозиции эпиков.