Allow ILaunchPluginService to filter handling classes based on constant pool#122
Draft
embeddedt wants to merge 2 commits intoMcModLauncher:mainfrom
Draft
Allow ILaunchPluginService to filter handling classes based on constant pool#122embeddedt wants to merge 2 commits intoMcModLauncher:mainfrom
embeddedt wants to merge 2 commits intoMcModLauncher:mainfrom
Conversation
Technici4n
reviewed
Dec 14, 2023
Technici4n
suggested changes
Dec 15, 2023
| case INT: | ||
| case FLOAT: | ||
| case NAME_TYPE: | ||
| case INDY: |
| continue; | ||
| } | ||
| // Filter out classes that don't match the constants filter | ||
| if (!ClassConstantPoolParser.constantPoolMatches(plugin.constantsFilter(className, reason), inputClass)) { |
There was a problem hiding this comment.
We need a way to opt-out of this behavior in case it causes issues (for example due to forgetting to update the constant pool parser). Probably via an env variable or ML arg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
constantsFiltermethod onILaunchPluginService. The intent of this is to allow transformers like RuntimeDistCleaner to be implemented more efficiently, by skipping parsing of the class file if the constant pool does not contain a given byte sequence. This should work because if theDistannotation were to be present in the class, it would have to be in the constant pool.Using this feature is optional and existing
ILaunchPluginServiceimplementations will continue to work as before without changes.