This repository was archived by the owner on Jun 11, 2019. It is now read-only.
Added support to keep containers by their container name#22
Merged
mikljohansson merged 2 commits intoMeltwaterArchive:masterfrom Mar 31, 2016
Merged
Added support to keep containers by their container name#22mikljohansson merged 2 commits intoMeltwaterArchive:masterfrom
mikljohansson merged 2 commits intoMeltwaterArchive:masterfrom
Conversation
run.sh
Outdated
| fi | ||
| done | ||
| fi | ||
| if [ -n "${KEEP_CONTAINERS_NAMED}" ]; then |
Contributor
There was a problem hiding this comment.
A bit of duplication with this block here, perhaps something that could be refactored out as a bash function?
Contributor
Author
|
Ok, I pulled that out into a function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a variable called KEEP_CONTAINERS_NAMED which allows you to save containers by their container name instead of just matching on image name.
I am using this to keep around all containers with names like "*-data", since that is the convention I use for my data volume containers.