Skip to content

Conversation

@LittleBeannie
Copy link
Collaborator

@LittleBeannie LittleBeannie commented Apr 8, 2024

This PR covers:

  1. Unify the output of wlr and maxcombo as a list containing

    • method,
    • parameter,
    • estimate,
    • se,
    • z
    • p_value and corr (only for maxcombo).
  2. Cleanup fh_weight, mb_weight and early_zero_weight, which only assigns weights to subjects. And the calculation of the z-score, estimation, se, is done in wlr().

  3. Update maxcombo.

# Old workflow
sim_pw_surv(n = 200) |>
   cut_data_by_event(150) |>
   counting_process(arm = "experimental") |>
   fh_weight(rho_gamma = data.frame(rho = (0, 0, 1, 1), gamma = (0, 1, 0, 1)), return_corr = TRUE) |>
   pvalue_maxcombo()

# New workflow
sim_pw_surv(n = 200) |>
   cut_data_by_event(150) |>
   maxcombo(rho = c(0, 0), gamma = c(0, 0.5), return_corr = TRUE)
  1. Revise sim_fixed_n to fit into the new output of wlr or maxcombo.
  2. Update related tests.

@LittleBeannie LittleBeannie linked an issue Apr 8, 2024 that may be closed by this pull request
@LittleBeannie LittleBeannie marked this pull request as draft April 8, 2024 18:33
@LittleBeannie LittleBeannie self-assigned this Apr 8, 2024
@LittleBeannie LittleBeannie added the development New feature or request label Apr 8, 2024
@LittleBeannie LittleBeannie changed the title standardize fh_weight output standardize wlr and maxcombo output Apr 10, 2024
@LittleBeannie LittleBeannie marked this pull request as ready for review April 11, 2024 18:37
@LittleBeannie LittleBeannie requested a review from keaven April 11, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardized fh_weight output

3 participants