Skip to content

Create new file rather than overwrite original recipe in configure_for/update_recipe #237

@chrisbillowsMO

Description

@chrisbillowsMO

Issue #18 / #227 automated the modification of the ESMValTool recipe. The code currently overwrites the original recipe with the modified version.

The code should not do this. It should retain the original file and create a modified version as a new file.

Per this @ehogan comment from the PR:

I notice that the tests have some additional code to handle that the recipe is being overwritten and I also notice the mv step above. I wonder whether there is a way to have the input (original) recipe and the output (modified) recipe in separate locations so that the additional code from the tests (and potentially the mv above) can be removed?

The mv step being referred to is =mv ${RECIPE_NAME} ${RECIPE_PATH}.

To consider: by default, esmvaltool recipes get ${RECIPE_NAME} doesn't take a directory argument. From memory (needs checking!) the default save location is {CYLC_WORKFLOW_SHARE_DIR} itself - which would possibly be undesirable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    configureAnything related to configurationenhancementNew feature or requestneeds refinementThis issue needs to be refinedrecipeAnything related to ESMValToolroseAnything related to Rosetechnical debtTechnical debt in CMEW

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions