Creating diagnostic for reading observation from Cardington single point location#1890
Open
mo-jbrooke wants to merge 18 commits intomainfrom
Open
Creating diagnostic for reading observation from Cardington single point location#1890mo-jbrooke wants to merge 18 commits intomainfrom
mo-jbrooke wants to merge 18 commits intomainfrom
Conversation
…int location. Adding CSET recipe and timeseries plot in loaders.
Allows constraining on the presence and value of cube attributes.
…ator Add attribute constraint operator
…s are not specified as coordinates
…ffice/CSET into 1750_2m_Cardington_air_temperature
jfrost-mo
changed the title
jfrost-mo
requested changes
Feb 18, 2026
Member
jfrost-mo
left a comment
jfrost-mo
left a comment
There was a problem hiding this comment.
Given a quick look over, and while there are a few things that need tidying up or testing it is overall looking very good.
src/CSET/operators/regrid.py
Outdated
| category=BoundaryWarning, | ||
| stacklevel=2, | ||
| ) | ||
| if np.abs((lat_tr - lat_pt)) > 0.1 or np.abs((lat_tr > lat_pt)) > 0.1: |
Member
There was a problem hiding this comment.
What minimum resolution data does this allow? Would you be able to compare quarter degree ERA5 for example?
| for attr in iter_maybe(attribute): | ||
| cube.attributes.pop(attr, None) | ||
|
|
||
| cubes = cubes.merge() |
Member
There was a problem hiding this comment.
Suggested change
| cubes = cubes.merge() | |
| # Combine things that can be merged due to remove removing the | |
| # attributes. | |
| cubes = cubes.merge() |
Add a comment explaining why this is needed.
Deleting this unwanted file. The old version is tracked in the Git history.
…ffice/CSET into 1750_2m_Cardington_air_temperature
Added error handling for attribute retrieval in read.py.
jfrost-mo
reviewed
Feb 23, 2026
Member
There was a problem hiding this comment.
File should be deleted. .nfs files like this usually indicate that a program has the file open still.
…ffice/CSET into 1750_2m_Cardington_air_temperature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding CSET recipe and timeseries plot in loaders.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.