Skip to content

Replace RuntimeErrors with custom exceptions #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t00sa wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Replace RuntimeErrors with custom exceptions #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d82dea4
Replace RuntimeErrors with custom exceptions
t00sa Aug 22, 2025
7e378dd
Fix flake8 problems
t00sa Aug 22, 2025
e420c7d
Remove old FabException references
t00sa Oct 21, 2025
bd90b22
Merge changes from main branch
t00sa Oct 21, 2025
fff620d
Remove most built-in python exceptions
t00sa Oct 22, 2025
15eb28b
Fix problems with CI testing
t00sa Oct 22, 2025
ebbb4bf
Add note about ExceptionGroup issue to docstring
t00sa Oct 23, 2025
7b52c47
Apply remaining reviewer suggestions
t00sa Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ jobs:
pip install .[dev]
pip install .[docs]

# Some of the system tests require git to be configured
- name: Set up git configuration
run: |
git config --global user.email "fab"
git config --global user.name "Fab Testing"
Comment on lines +77 to +78
Copy link
Collaborator

@yaswant yaswant Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you need this for git merge. There is no potential issue here, but does this have to be --global config? I know there is no strict validation here, but wondering if [email protected] as user.email would be better?

Copy link
Contributor Author

@t00sa t00sa Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably doesn't have to be, but this is what git suggests when the configuration items don't exist


- name: Type check with mypy
run: python -m mypy source tests

Expand Down
4 changes: 0 additions & 4 deletions source/fab/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,3 @@
logger = logging.getLogger(__name__)
logger.addHandler(logging.StreamHandler(sys.stdout))
logger.setLevel(logging.INFO)


class FabException(Exception):
pass
4 changes: 2 additions & 2 deletions source/fab/artefacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ def replace(self, artefact: Union[str, ArtefactSet],

art_set = self[artefact]
if not isinstance(art_set, set):
raise RuntimeError(f"Replacing artefacts in dictionary "
f"'{artefact}' is not supported.")
name = artefact if isinstance(artefact, str) else artefact.name
raise AssertionError(f"{name} is not mutable")
art_set.difference_update(set(remove_files))
art_set.update(add_files)

Expand Down
Loading