Verniered time calipers pi25 #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-marqh
requested review from
EdHone,
MatthewHambley,
andrewcoughtrie,
mike-hobson and
stevemullerworth
as code owners
mo-marqh
requested review from
t00sa
and removed request for
MatthewHambley,
andrewcoughtrie,
mike-hobson and
stevemullerworth
|
The set of new calipers and the implementation all look sound to me @mo-marqh, I have had some issues building the code with vernier though. I checked out your core branch and attempted to build simple diffusion with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @EdHone
Code Reviewer: @t00sa
This stand alone change is part of a change set targeting performance management and optimisation, derived from https://code.metoffice.gov.uk/trac/lfric_apps/ticket/1002
This change set targets the additional and renamed calipers for timings within
lfric_core.Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
using this branch
acceptable (e.g. kgo changes)
tests, unit tests, etc.)
and have been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_core - verniered_time_calipers_PI25/run4
Suite Information
Task Information
✅ succeeded tasks - 372
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
interface, optimisation scripts, LFRic data structure code) then please
contact the
[email protected]
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review