Skip to content

Resolve .NET Core debugging on Windows#798

Merged
philliphoff merged 3 commits intomasterfrom
philliphoff-winfix
Feb 21, 2019
Merged

Resolve .NET Core debugging on Windows#798
philliphoff merged 3 commits intomasterfrom
philliphoff-winfix

Conversation

@philliphoff
Copy link
Member

gdziadkiewicz had discovered that I broke debugging .NET Core in Docker on Windows with the previous Alpine support commit, and was also kind enough to suggest a workaround in PR #795 (a larger change to support F# project debugging).

For simplicity, I've split that workaround into a separate PR and updated/verified it to work across Mac/Ubuntu/Windows. The changes are:

  • Use a double-quoted script string to obtain the container debugger type when VS Code is running on Windows.
  • Normalize the relative (host) path returned by the debugging client for the target (i.e. container's) platform.

@philliphoff
Copy link
Member Author

@StephenWeatherford @EricJizbaMSFT Could either of you take a quick look at this when you get a chance (as a community PR is dependent upon it)? Thanks!

@philliphoff philliphoff merged commit 0107600 into master Feb 21, 2019
@philliphoff philliphoff deleted the philliphoff-winfix branch February 21, 2019 23:20
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants