Resolve .NET Core debugging on Windows#798
Merged
philliphoff merged 3 commits intomasterfrom Feb 21, 2019
Merged
Conversation
Member
Author
|
@StephenWeatherford @EricJizbaMSFT Could either of you take a quick look at this when you get a chance (as a community PR is dependent upon it)? Thanks! |
StephenWeatherford
approved these changes
Feb 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gdziadkiewicz had discovered that I broke debugging .NET Core in Docker on Windows with the previous Alpine support commit, and was also kind enough to suggest a workaround in PR #795 (a larger change to support F# project debugging).
For simplicity, I've split that workaround into a separate PR and updated/verified it to work across Mac/Ubuntu/Windows. The changes are: