Add debugging and dockerfile creation for fsharp dotnet core projects.#795
Merged
philliphoff merged 5 commits intomicrosoft:masterfrom Mar 7, 2019
Conversation
gdziadkiewicz
force-pushed
the
feature/debuggin_and_creation_of_docker_files_for_dotnet_core_fsharp_projs
branch
from
0e6abc8 to
442cf2d
Compare
gdziadkiewicz
force-pushed
the
feature/debuggin_and_creation_of_docker_files_for_dotnet_core_fsharp_projs
branch
from
442cf2d to
26183ea
Compare
gdziadkiewicz
changed the title
gdziadkiewicz
commented
Feb 16, 2019
gdziadkiewicz
commented
Feb 16, 2019
Contributor
philliphoff
reviewed
Feb 19, 2019
Member
|
You might also look over the |
gdziadkiewicz
force-pushed
the
feature/debuggin_and_creation_of_docker_files_for_dotnet_core_fsharp_projs
branch
from
e6cc443 to
e1ce690
Compare
…les_for_dotnet_core_fsharp_projs
…rry project file name.
Contributor
Author
|
Review issues solved - ready for review. |
Member
|
@gdziadkiewicz Sorry, I've been out of the office the past couple of days; will try to get to this in the next couple. |
Contributor
|
@philliphoff How close is this to being ready? Need it in by tomorrow if for this release, thx. |
Member
|
@StephenWeatherford The changes themselves now look ok to me; let me see if I can do some testing this afternoon. |
Member
|
Tested successfully across Windows, Mac, and Linux (Ubuntu). |
philliphoff
approved these changes
Mar 7, 2019
gdziadkiewicz
deleted the
feature/debuggin_and_creation_of_docker_files_for_dotnet_core_fsharp_projs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested only on Windows 10 machine with Docker for Windows using template generated fsharp app and generated dockerfile.
After refreshing my branch with master the debugging feature stopped working for my setup and the changes in commit e6cc443 are workarounds for those problems:Before changing the single quotes to double quotes in platform checking docker exec call it resulted inSyntax error: Unterminated quoted stringerror.The call tothis.debuggerClient.getDebuggerwas returning path with backslashes. This also caused error. Please confirm that this is the right place to do the normalization if you decide to merge this.