Add 'Alternatives Considered' section#307
Merged
fabiorocha merged 4 commits intomasterfrom May 6, 2020
Merged
Conversation
samtan-msft
approved these changes
May 5, 2020
connor-moody
approved these changes
May 5, 2020
fabiorocha
added
the
URLProtocolHandler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #286 by adding an "Alternatives Considered" section. We might expand that section as other ideas at the explainer level are suggested.
We debated the alternative proposed long and hard but ultimately feel that having the property being consumed at install time is the least confusing approach. The next step is addressing security concerns with that approach, tracked mainly in #230. We are still discussing that internally and will submit a PR soon.
/cc @dmurph