Skip to content

Ticket #5087: fix incorrect disabling of widgets in the Configuration dialog#5087

Merged
zyv merged 2 commits intoMidnightCommander:masterfrom
tuffnatty:cfg-dialog-fixes
Apr 5, 2026
Merged

Ticket #5087: fix incorrect disabling of widgets in the Configuration dialog#5087
zyv merged 2 commits intoMidnightCommander:masterfrom
tuffnatty:cfg-dialog-fixes

Conversation

@tuffnatty
Copy link
Copy Markdown
Contributor

Proposed changes

These patches fix a couple of typos in dca06a6. One of the typos resulted in non-disabling the Preallocate option on platforms without HAVE_POSIX_FALLOCATE. The other was rather harmless, tried to disable two widgets instead of one while disabling the Esc Timeout input widget.

Checklist

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@github-actions github-actions Bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Apr 5, 2026
@github-actions github-actions Bot added this to the Future Releases milestone Apr 5, 2026
@zyv zyv added area: config Configuration INI files and removed needs triage Needs triage by maintainers labels Apr 5, 2026
@zyv zyv modified the milestones: Future Releases, 4.9.0 Apr 5, 2026
@zyv zyv changed the title Configuration dialog fixes Fix incorrect disabling of widgets in the Configuration dialog Apr 5, 2026
@zyv zyv requested a review from mc-worker April 5, 2026 06:13
@zyv zyv changed the title Fix incorrect disabling of widgets in the Configuration dialog Ticket #5087: fix incorrect disabling of widgets in the Configuration dialog Apr 5, 2026
@zyv
Copy link
Copy Markdown
Member

zyv commented Apr 5, 2026

/rebase

Signed-off-by: Phil Krylov <phil@krylov.eu>
Signed-off-by: Phil Krylov <phil@krylov.eu>
@zyv zyv merged commit 5b3bed7 into MidnightCommander:master Apr 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: config Configuration INI files prio: medium Has the potential to affect progress

Development

Successfully merging this pull request may close these issues.

3 participants