Skip to content

Add Brotli (br) extension to filehighlight.ini#5101

Merged
zyv merged 1 commit intoMidnightCommander:masterfrom
sergey-dryabzhinsky:master
Apr 26, 2026
Merged

Add Brotli (br) extension to filehighlight.ini#5101
zyv merged 1 commit intoMidnightCommander:masterfrom
sergey-dryabzhinsky:master

Conversation

@sergey-dryabzhinsky
Copy link
Copy Markdown
Contributor

@sergey-dryabzhinsky sergey-dryabzhinsky commented Apr 22, 2026 •
edited by zyv
Loading

Missing brotli extension

Proposed changes

Miss .br highlights

Checklist

👉 Our coding style can be found here: https://midnight-commander.org/coding-style/ 👈

  • I have referenced the issue(s) resolved by this PR (if any)
  • I have signed-off my contribution with git commit --amend -s
  • Lint and unit tests pass locally with my changes (make indent && make check)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@github-actions github-actions Bot added this to the Future Releases milestone Apr 22, 2026
@github-actions github-actions Bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Apr 22, 2026
mc-worker
mc-worker reviewed Apr 22, 2026
View reviewed changes
Comment thread misc/filehighlight.ini Outdated
@sergey-dryabzhinsky
Copy link
Copy Markdown
Contributor Author

sergey-dryabzhinsky commented Apr 22, 2026 •
edited
Loading

Maybe .udeb should be added too. And .ddeb.
In another pr.

@mc-worker
Copy link
Copy Markdown
Contributor

mc-worker commented Apr 25, 2026

Please squash commits.

@sergey-dryabzhinsky
Copy link
Copy Markdown
Contributor Author

sergey-dryabzhinsky commented Apr 25, 2026

I'll try

@sergey-dryabzhinsky
Copy link
Copy Markdown
Contributor Author

sergey-dryabzhinsky commented Apr 25, 2026

@mc-worker , Done

@sergey-dryabzhinsky
Copy link
Copy Markdown
Contributor Author

sergey-dryabzhinsky commented Apr 25, 2026

Although brotli viewing seems not working.

@zyv zyv added area: config Configuration INI files and removed needs triage Needs triage by maintainers labels Apr 26, 2026
@zyv zyv modified the milestones: Future Releases, 4.9.0 Apr 26, 2026
@zyv zyv changed the title Update filehighlight.ini - miss brotli ext Add Brotli extension to filehighlight.ini Apr 26, 2026
@zyv zyv changed the title Add Brotli extension to filehighlight.ini Add Brotli (br) extension to filehighlight.ini Apr 26, 2026
@sergey-dryabzhinsky @zyv
Ticket MidnightCommander#5100: add Brotli (br) extension to `filehi…
10e7aa3 
…ghlight.ini`

Signed-off-by: Sergey Dryabzhinsky <sergey.dryabzhinsky+github@gmail.com>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
@zyv zyv changed the title Add Brotli (br) extension to filehighlight.ini Add Brotli (br) extension to filehighlight.ini Apr 26, 2026
@zyv
Copy link
Copy Markdown
Member

zyv commented Apr 26, 2026

Although brotli viewing seems not working.

Support for viewing Brotli was contributed to master in #4835 by @moose-kazan. Your change only affects the display of the files. If it's not working for you, then maybe he can help if you explain what you are doing and what is not working. You need to have the tool installed though, but I guess you do.

@zyv zyv merged commit e2bdf5e into MidnightCommander:master Apr 26, 2026
16 of 17 checks passed
@sergey-dryabzhinsky
Copy link
Copy Markdown
Contributor Author

sergey-dryabzhinsky commented Apr 26, 2026

@zyv yeah, it's not causing by the pr changes. I'll investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mc-worker mc-worker mc-worker left review comments

Assignees

No one assigned

Labels

area: config Configuration INI files prio: medium Has the potential to affect progress

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

Add br extension to archive highlighting ini

3 participants

@sergey-dryabzhinsky @mc-worker @zyv