Merged
Conversation
1 task
Contributor
Author
|
This may potentially not be needed as I think a fix is going to be merged upstream soon. Though, we may want this merged just to fix the 3 months of inbetween versions though people could be using (it's more likely users would update this extension rather than the webui). Coyote-A/ultimate-upscale-for-automatic1111#111 (comment)
|
4 tasks
tiangles
pushed a commit
to diffus-me/sd-webui-controlnet
that referenced
this pull request
Aug 18, 2023
* Fix mask blur * Prioritize mask_blur_x over mask_blur * Update mask blur sigma values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1888, AUTOMATIC1111/stable-diffusion-webui#12428
This has been broken for about 3 months now and was never accounted for in this extension. The webui switched from using
mask_blurto separate attributes formask_blur_xandmask_blur_yin 1.4.0, so themask_blurwas read asNoneby ControlNet. AUTOMATIC1111/stable-diffusion-webui#10295Uses the same code from here to modify the mask: https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/26c92f056acc795af5066779f1b8aedb8dfa983d/modules/processing.py#L1287-L1297