Add typescript types and onboarding ping#525
Conversation
Olwiba
left a comment
Olwiba
left a comment
There was a problem hiding this comment.
I'm happy with the code changes here, we just need to update the type definitions to match before we can look to ship this. Nice one 🚀
PanosNB
left a comment
PanosNB
left a comment
There was a problem hiding this comment.
Primary concern is we need to get the tests to pass before releasing anything. Also check some minor typos and questions please: :-)
PanosNB
left a comment
PanosNB
left a comment
There was a problem hiding this comment.
Ok for prerelease and thus, beta-testing on our systems
| // Request failed | ||
| metadata.ping.failedPings++; | ||
| } | ||
| }) |
There was a problem hiding this comment.
This is a bit ugly here, we normally put the .catch in the line. No worries for now
PanosNB
left a comment
PanosNB
left a comment
There was a problem hiding this comment.
Again, all good for prerelease and soaking in our systems
phillip-haydon
left a comment
phillip-haydon
left a comment
There was a problem hiding this comment.
Couple of comments.
| { | ||
| "name": "raygun4js", | ||
| "version": "2.28.0", | ||
| "version": "3.1.1", |
There was a problem hiding this comment.
@Hamish-taylor Update this please (as you suggested)
| "title": "Raygun4js", | ||
| "description": "Raygun.com plugin for JavaScript", | ||
| "version": "3.0.1", | ||
| "version": "3.1.1", |
CmdrKeen
left a comment
CmdrKeen
left a comment
There was a problem hiding this comment.
Looks good to me @Hamish-taylor - just updates on the version numbers.
Co-authored-by: Jasen Palmer <palmer.jasen@gmail.com>
PanosNB
left a comment
PanosNB
left a comment
There was a problem hiding this comment.
Ok, follow the usual prelease/soaking process please
6 participants
No description provided.