Skip to content

Limit Ping to be less frequent.#532

Merged
phillip-haydon merged 4 commits intomasterfrom
ph/limit-ping
Nov 25, 2024
Merged

Limit Ping to be less frequent.#532
phillip-haydon merged 4 commits intomasterfrom
ph/limit-ping

Conversation

@phillip-haydon
Copy link
Copy Markdown
Contributor

This changes the way Ping happens by:

  • Limiting ping to be once per session.
  • Failure to ping will re-attempt at intervals of 10/20/40/80/120 seconds before stopping.
  • Re-ping if data changes. This happens if the app sent true for rum and then changed to false, it would cause a re-ping to happens.

PanosNB
PanosNB previously approved these changes Nov 19, 2024
Copy link
Copy Markdown

@PanosNB PanosNB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Clear for pre release on our systems and monitor the situation

Copy link
Copy Markdown

@MattByers MattByers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phillip-haydon phillip-haydon merged commit 5cedcbb into master Nov 25, 2024
@phillip-haydon phillip-haydon deleted the ph/limit-ping branch November 25, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants