Conversation
miquelbeltran
left a comment
miquelbeltran
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the code formatting as well
|
This PR is on hold for now, until I get an update about how we wish to proceed. |
|
Can we merge this PR? |
|
@sumitramanga, please advise - context from when we put this on hold was that we might want to re-add the ping functionality if onboarding continued to have issues. it's been a while now so it would be great if we could get this closed/merged |
|
@Olwiba I'll check with JD |
|
From JD -
We can go ahead and remove it. It's not doing anything related to onboarding anymore |
|
great, looks like this one is unblocked now :) @miquelbeltran, just checking you're still happy with the changes in the PR? |
|
yep, LGTM! |
|
moving this one forward to pre-release. will ensure presoak + approval by JD before we officially release it |
|
ref: #540 |
4 participants
Remove ping functionality from provider
This PR removes the send ping functionality from the provider as it's not longer required as part of the onboarding flow inside the Raygun application.