Merged
Conversation
Delete files Replace per validator schemas Add a .gitignore file
This was referenced Nov 23, 2021
This was referenced Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56
This Pull Request will reorganize the Json Schemas versions per folder instead of using the tags. This is done because:
Since some fixes have been introduced in the Json Schemas used in the validator, they will be taken as the base. A review will also be done to assess changes that happened on the Json Schema repo that do not appear in the gbfs-validator repo, to make sure all fixes are included here.
This PR also addresses some of the issues and PR's related to errors in the schemas that have been open on this repository and on the gbfs-validator repository.
max_range_metersconditionally required onvehicle_types.json#45 is already fixed with the validator schemasvehicles_types_availabletovehicle_types_available#50 is addressed in 175d53401f3a5d