Replace required with boolean (invalid) to array#92
Merged
richfab merged 2 commits intoMobilityData:masterfrom Jul 7, 2023
Merged
Replace required with boolean (invalid) to array#92richfab merged 2 commits intoMobilityData:masterfrom
required with boolean (invalid) to array#92richfab merged 2 commits intoMobilityData:masterfrom
Conversation
Signed-off-by: Pierrick <mulotmail@gmail.com>
richfab
reviewed
Jul 6, 2023
richfab
requested changes
Jul 6, 2023
Contributor
There was a problem hiding this comment.
LGTM. Thank you @PierrickP!
I added a suggestion on v3.0-RC/gbfs.json.
Co-authored-by: Fabien Richard-Allouard <fabien@mobilitydata.org>
richfab
approved these changes
Jul 7, 2023
Contributor
richfab
left a comment
richfab
left a comment
There was a problem hiding this comment.
LGTM. Merging now!
Thank you @PierrickP!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would correct validate https://data-sharing.tier-services.io/tier_paris/gbfs/3.0 as invalid
As additional properties are not forbidden,
enwas accepted.This PR correctly require
feedsto be required