Skip to content

Fix up small issues in readme#6

Merged
MohamedRejeb merged 1 commit intoMohamedRejeb:mainfrom
ire4ever1190:main
May 17, 2023
Merged

Fix up small issues in readme#6
MohamedRejeb merged 1 commit intoMohamedRejeb:mainfrom
ire4ever1190:main

Conversation

@ire4ever1190
Copy link
Contributor

@ire4ever1190 ire4ever1190 commented May 17, 2023

Was following the readme to test out the lib (cool library 🎉) but ran into a few small problems in the readme

  • Using input which doesn't exist instead of html
  • Using a builder when a handler was needed instead (The first instance of this isn't a bug, but the variable was called "handler" so assumed you would want a handler instead of a builder)

@ire4ever1190
Fix up small issues
7c965ba 
 - Using nonexistant `input` variable instead of `html` (This also happened in later section)

 - Assigning a builder to a handler variable (Not an issue, but semantically it makes sense to build it)

 - Trying to pass a builder instead of a built instance
@MohamedRejeb MohamedRejeb self-requested a review May 17, 2023 10:33
MohamedRejeb
MohamedRejeb approved these changes May 17, 2023
View reviewed changes
Copy link
Owner

@MohamedRejeb MohamedRejeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@MohamedRejeb MohamedRejeb merged commit 72363c8 into MohamedRejeb:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MohamedRejeb MohamedRejeb MohamedRejeb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ire4ever1190 @MohamedRejeb