fix(web): use platform-specific modifier key for search shortcut#1372
Merged
fix(web): use platform-specific modifier key for search shortcut#1372
Conversation
Consolidate the repeated `isMacOS() ? e.metaKey : e.ctrlKey` pattern into a shared utility with cached platform detection.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Entire-Checkpoint: 82d789f1f018
…upport" This reverts commit f2d7ccc. Entire-Checkpoint: 6fb0000a4ae0
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A
Description
Fix Cmd+F / Ctrl+F search shortcut using
e.metaKey || e.ctrlKey, which incorrectly accepts both modifier keys on all platforms. On macOS, Ctrl+F should not trigger search; on Windows/Linux, Cmd (meta) key should not trigger search.Now uses platform-specific modifier: Cmd on macOS, Ctrl elsewhere. Extracted a shared
hasPlatformModifier(e)utility to consolidate the repeated pattern acrosschat-conversation.tsxandsessions.tsx, with cached platform detection to avoid recalculating on every keydown.Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.