fix(cli): redirect stderr before MCP loading to prevent terminal pollution#1581
Merged
RealKai42 merged 1 commit intoMoonshotAI:mainfrom Mar 25, 2026
Merged
Conversation
…ution MCP server subprocesses (e.g. mcp-remote) write debug/OAuth logs to stderr. Previously, `redirect_stderr_to_logger()` was called *after* `KimiCLI.create()`, which meant MCP server stderr output during startup went directly to the user's terminal, polluting the TUI. Move the redirect call to just before `create()` — CLI argument parsing has already completed at this point, so Typer/Click startup errors are no longer a concern. Fatal errors from `create()` remain visible because `_emit_fatal_error()` writes to the saved original stderr fd.
RealKai42
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #1214 — Verbose MCP debug messages printed to console when starting with
-Cflag and OAuth MCP servers.Also related: #1215 (attempted fix, still open), #1501 (closed without merge).
Description
MCP server subprocesses (e.g.
mcp-remote) write debug and OAuth logs to stderr. Previously,redirect_stderr_to_logger()was called afterKimiCLI.create(), which meant MCP server stderr output during startup went directly to the user's terminal, polluting the TUI.Root Cause
Fix
Move
redirect_stderr_to_logger()to just beforeKimiCLI.create(). At this point CLI argument parsing has already completed, so Typer/Click startup errors are no longer a concern. Fatal errors fromcreate()remain visible because_emit_fatal_error()writes to the saved original stderr fd (not affected by the redirect).Before / After
Tested with a noisy MCP server that writes 5 debug lines to stderr during startup:
Checklist
make gen-changelogto update the changelog.