No search on enter if filters are unchanged #1631#1642
Merged
Mottie merged 4 commits intoMottie:masterfrom Dec 1, 2019
Merged
Conversation
Fixing Mottie#1631 by not treating the enter key as a key press and thus not executing the search if enter is pressed while no filters were changed.
Only reset the lastSearch and lastCombinedFilter variables if the filters were equal before. We don't need to "force filter refresh" if the filters were not equal anyways.
Only reset the lastSearch and lastCombinedFilter variables if the filters were equal before. We don't need to "force filter refresh" if the filters were not equal anyways.
Fixing Mottie#1631 by not treating the enter key as a key press and thus not executing the search if enter is pressed while no filters were changed.
Owner
|
Hi @larsbonczek! Thanks for your help with this bug! Sorry it took me so long to respond and get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #1631 by not treating the enter key as a key press and thus not executing the search if enter is pressed while no filters were changed.