Closed
Conversation
8a39dd1 to
9432ad1
Compare
Bumps [sass](https://github.com/sass/dart-sass) from 1.59.3 to 1.77.2. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.59.3...1.77.2) --- updated-dependencies: - dependency-name: sass dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
9432ad1 to
63d0890
Compare
mmmavis
requested changes
May 23, 2024
Collaborator
mmmavis
left a comment
There was a problem hiding this comment.
From https://github.com/sass/dart-sass/blob/main/CHANGELOG.md#1670, in v1.67.0
Breaking change: As a consequence of the change in calculation parsing described above, calculation functions containing interpolation are now parsed more strictly than before. However, almost all interpolations that would have produced valid CSS will continue to work. The only exception is #{$variable}% which is not valid in Sass and is no longer valid in calculations. Instead of this, either use $variable directly and ensure it already has the % unit, or write ($variable * 1%).
We will need to update our code before we can merge this PR.
Contributor
Author
|
Superseded by #12412. |
Collaborator
|
➤ Simon Acosta Torres commented: PR has been closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps sass from 1.59.3 to 1.77.2.
Release notes
Sourced from [sass's releases](https://github.com/sass/dart-sass/releases).
... (truncated)
Changelog
Sourced from [sass's changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md).
... (truncated)
Commits
5121eb1Don't treat underscores as hyphens for the purpose of error checking ([Foundation site: Add page title to html head #2247](https://redirect.github.com/Don't treat underscores as hyphens for the purpose of error checking sass/dart-sass#2247))bdc08fdMerge pull request [Buyers Guide: Add product names to page titles #2246](https://redirect.github.com/Fix deprecation flags in the CLI and add tests sass/dart-sass#2246) from sass/deprecation-cli9a9e483Add a test to ensure the sass_api dartdoc version matches sass8c48a01Expand dartdoc range for sass_api to match sassc9f0d3fFix deprecation flags in the CLI and add tests54a6decBump lints from 3.0.0 to 4.0.0 ([Bump boto3 from 1.9.40 to 1.9.48 #2242](https://redirect.github.com/Bump lints from 3.0.0 to 4.0.0 sass/dart-sass#2242))372f15cFixMapExtensions.getOption()for nullable types ([update python version used on Heroku #2241](https://redirect.github.com/FixMapExtensions.getOption()for nullable types sass/dart-sass#2241))85f39d5Allow at-rules in@keyframesblocks ([Add mini seal to Related Products #2236](https://redirect.github.com/Allow at-rules in@keyframesblocks sass/dart-sass#2236))264b2d5Deprecate function and mixin names beginning with--([Remove some <div>s from our templates #2230](https://redirect.github.com/Deprecate function and mixin names beginning with--sass/dart-sass#2230))f145e1cThrow errors for misplaced statements in keyframe blocks ([Bump shelljs from 0.8.2 to 0.8.3 #2226](https://redirect.github.com/Throw errors for misplaced statements in keyframe blocks sass/dart-sass#2226))Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)┆Issue is synchronized with this Jira Story