Image carousel frontend#15609
Open
mmmavis wants to merge 16 commits intofeature/speaker-component-integrationfrom
Open
Image carousel frontend#15609mmmavis wants to merge 16 commits intofeature/speaker-component-integrationfrom
mmmavis wants to merge 16 commits intofeature/speaker-component-integrationfrom
Conversation
…ard carousels to extend SlidingCarousel base
mmmavis
force-pushed
the
TP1-3603-image-carousel
branch
from
749b994 to
050f01e
Compare
mmmavis
commented
Mar 20, 2026
| @@ -0,0 +1,229 @@ | |||
| /** | |||
Collaborator
Author
There was a problem hiding this comment.
code in this file pretty much was all extracted from the original portrait-card-carousel.js
mmmavis
commented
Mar 20, 2026
| ) | ||
| description = CustomRichTextBlock( | ||
| required=False, | ||
| label="Description", |
Collaborator
Author
There was a problem hiding this comment.
setting label so the field doesn't appear as Rich text in CMS
…zilla/foundation.mozilla.org into TP1-3603-image-carousel
mmmavis
changed the title
mmmavis
commented
Mar 23, 2026
| @@ -1,229 +1,35 @@ | |||
| const SELECTORS = { | |||
Collaborator
Author
There was a problem hiding this comment.
code extracted into foundation_cms/static/js/blocks/util/sliding_carousel.js
Collaborator
|
Looking great so far @mmmavis I do have some questions regarding desktop viewport layout: 
Is this bottom margin zeroed intentionally? 
This bottom margin looks a bit narrow too. It seems in the spec we have a bit of space in between these elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs/issues: Jira TP1-3603
Description
ImageCarouselBlock.portrait_card_carousel.jsinto a newutil/sliding_carousel.js. BothImageCarouselandPortraitCardSetCarouselsnow extend it.$triangle-widthas a shared variable and addsmargin-leftso the left triangle offset is correctly accounted for in the block's layout.Note that the pagination controls and opacity of the peekaboo item in the image carousel follow the existing pattern (like portrait card carousel) until further design decision is made.
Link to sample test page: https://foundation-s-tp1-3603-i-efw1ml.mofostaging.net/en/carousel-test/
I've included Portrait Card Set examples in the test page for comparison.