feat(general-page): display title as H1 when hero is absent, fix side-by-side hero spacing#15636
Open
feat(general-page): display title as H1 when hero is absent, fix side-by-side hero spacing#15636
Conversation
This was referenced Mar 26, 2026
Collaborator
|
Hey @mmmavis I think the no-hero standalone H1 is still missing a margin-bottom in this one. |
Collaborator
Author
|
Hi @beccaklam , I have set up the review app again. Could you give it a 👀 ? Also wanna defer Ram's question to you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<h1>when no hero block is configured, ensuring the page always has a visible headingmargin-topwhen there is no hero imageRelated PRs/issues: Jira TP1-3681
Sample test pages: