Skip to content

Updated Buyer's Guide og tag title, description, and image#2190

Merged
Pomax merged 12 commits intomasterfrom
issue-2184-bg-og
Nov 15, 2018
Merged

Updated Buyer's Guide og tag title, description, and image#2190
Pomax merged 12 commits intomasterfrom
issue-2184-bg-og

Conversation

@mmmavis
Copy link
Copy Markdown
Collaborator

@mmmavis mmmavis commented Nov 14, 2018 •
edited
Loading

Closes #2184

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2190 November 14, 2018 23:02 Inactive
Pomax
Pomax reviewed Nov 14, 2018
View reviewed changes
network-api/networkapi/buyersguide/templates/bg_base.html
<meta property="og:title" content="*Privacy Not Included: A Holiday Buyer’s Guide for Connected Products" />
{% endblock %}
<meta property="og:description" content="This year, learn what tech comes with privacy included, using Mozilla's buyer's guide for connected gadgets." />
<meta property="og:description" content="70 connected products rated on their safety and security" />
Copy link
Copy Markdown
Contributor

@Pomax Pomax Nov 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this dynamic? Like content="{{ products|length }} connected products ..."?

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2190 November 14, 2018 23:13 Inactive
@mmmavis
Copy link
Copy Markdown
Collaborator Author

mmmavis commented Nov 14, 2018

do not review yet

image

Description is missing in the preview. One online post says the title needs to be under 63 characters long for the description to show on Facebook. Let me test & verify it.

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2190 November 14, 2018 23:19 Inactive
@mmmavis
Copy link
Copy Markdown
Collaborator Author

mmmavis commented Nov 14, 2018 •
edited
Loading

(I removed the word Products from og:title as a test)

image

I think if we want description to show in Facebook preview title needs to fit in single line.

@kristinashu thoughts?

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2190 November 14, 2018 23:26 Inactive
@kristinashu
Copy link
Copy Markdown

kristinashu commented Nov 14, 2018

Ah ok, shoot. Could probably just do *Privacy Not Included: A Holiday Buyer’s Guide for the title but will confirm with Jen tomorrow (she's done for the day).

@mmmavis
Copy link
Copy Markdown
Collaborator Author

mmmavis commented Nov 14, 2018

@kristinashu No worries! Can you update the ticket (or here) and tag me when you get Jen's confirmation? Thanks!

@mmmavis mmmavis changed the title Updated Buyer's Guide og tag title, description, and image (WIP) Updated Buyer's Guide og tag title, description, and image Nov 14, 2018
@kristinashu
Copy link
Copy Markdown

kristinashu commented Nov 15, 2018

Jen says to use this title: *Privacy Not Included: A Buyer’s Guide for Connected Products

@kristinashu
Copy link
Copy Markdown

kristinashu commented Nov 15, 2018

So removing the word "holiday"

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2190 November 15, 2018 18:33 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2190 November 15, 2018 18:34 Inactive
@mmmavis mmmavis changed the title (WIP) Updated Buyer's Guide og tag title, description, and image Updated Buyer's Guide og tag title, description, and image Nov 15, 2018
@mmmavis mmmavis requested review from Pomax and kristinashu November 15, 2018 18:41
@mmmavis
Copy link
Copy Markdown
Collaborator Author

mmmavis commented Nov 15, 2018

image

you can test it out here as well: https://developers.facebook.com/tools/debug/

kristinashu
kristinashu approved these changes Nov 15, 2018
View reviewed changes
Copy link
Copy Markdown

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kristinashu
Copy link
Copy Markdown

kristinashu commented Nov 15, 2018

That debugger gives this warning, does that matter?

image

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2190 November 15, 2018 18:46 Inactive
@mmmavis
Copy link
Copy Markdown
Collaborator Author

mmmavis commented Nov 15, 2018

Missing fb:app_id should be fine! Thanks for catching that though.

@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2190 November 15, 2018 21:19 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2190 November 15, 2018 21:26 Inactive
@Pomax Pomax merged commit a731165 into master Nov 15, 2018
@Pomax Pomax deleted the issue-2184-bg-og branch November 15, 2018 21:46
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pomax Pomax Awaiting requested review from Pomax

1 more reviewer

@kristinashu kristinashu kristinashu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmmavis @kristinashu @Pomax