Conversation
Pomax
force-pushed
the
custom-emoji-mapping
branch
from
b9e259b to
a2254c8
Compare
| "optimize": "run-p optimize:**", | ||
| "server": "pipenv run python network-api/manage.py runserver", | ||
| "start": "npm i && npm run build-uncompressed && run-p server watch:**", | ||
| "start": "npm i && run-p build-uncompressed server watch:**", |
There was a problem hiding this comment.
mostly a dev Quality of Life change - this starts the server way earlier, so you can just reload the tab once webpack finishes the build, instead of getting a "server not found" for like... a minute
kristinashu
left a comment
kristinashu
left a comment
There was a problem hiding this comment.
Yes! So nice to see "not creepy!"
| // creepy by default. | ||
| // | ||
| // Note: this is a cosmetic value for scroll only. | ||
| const MAXIMUM_CREEPINESS_RATING = 80; |
There was a problem hiding this comment.
Are MINIMUM_HAPPINESS_RATING and MAXIMUM_CREEPINESS_RATING both fixed values unrelated to EMOJI_FRAME_HEIGHT and SPRITE_FRAME_COUNT? If there's any relationship between them I think it's worth adding some inline comments in case we decide to change the values for frame height and frame count in the future.
There was a problem hiding this comment.
There is zero relation between the two sets of numbers.
mmmavis
left a comment
mmmavis
left a comment
There was a problem hiding this comment.
I left one comment but code looks good to me! ✨
4 participants
Closes #2196, as long as we can make sure the minimum and maximum values are acceptable =)