Skip to content

fix to the donate popup GA label#2233

Merged
mmmavis merged 4 commits intomasterfrom
donate-modal-ga
Nov 20, 2018
Merged

fix to the donate popup GA label#2233
mmmavis merged 4 commits intomasterfrom
donate-modal-ga

Conversation

@Pomax
Copy link
Copy Markdown
Contributor

@Pomax Pomax commented Nov 19, 2018

Addresses the "donate tap" event not saying which page it was triggered on.

See #2024

Also see L15 in https://docs.google.com/spreadsheets/d/1x-CP_HYaAs3oRv2cjbSFu8w5Z938E4cyHQ3hvh17c6c/edit#gid=980429434

@Pomax Pomax requested a review from mmmavis November 19, 2018 21:28
@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2233 November 19, 2018 21:28 Inactive
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2233 November 19, 2018 21:50 Inactive
category: `buyersguide`,
action: `donate tap`,
label: `donate popup`
label: `donate popup on ${url}`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in https://docs.google.com/spreadsheets/d/1x-CP_HYaAs3oRv2cjbSFu8w5Z938E4cyHQ3hvh17c6c/edit#gid=980429434 it seems like we want "page title" instead?

row 15: donate popup on [page title]

Copy link
Copy Markdown
Contributor Author

@Pomax Pomax Nov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however, the page title is a constant string, so it would only ever be donate popup on Mozilla - *privacy not included" which I assume is not what we want. I figured the "url fragment" that actually tells us which page the donate modal ended up being clicked on made more sense, but maybe @xmatthewx can "make a ruling" here =)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense. Let's use whatever string will give us easiest at-a-glance understanding of when/where people are inspired to donate.

@Pomax Pomax requested a review from mmmavis November 20, 2018 18:10
@Pomax Pomax temporarily deployed to foundation-mofostaging-pr-2233 November 20, 2018 18:10 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants