Theme: Change Typography members to type BaseTypography

[danielchalmers]

• Reverts Revert "Theme: Change Typography members to type BaseTypography" #9423 which reverts Theme: Change Typography members to type BaseTypography #9368 aka restoring the original PR.
• Resolves Change theme class Typography members to type BaseTypography #4800
• Makes BaseTypography abstract to avoid accidents with new()

As this is technically a breaking change (more info in the linked PRs) this will be a part of v8.x.x, not v7.x.x.

[danielchalmers]

@ScarletKuro I think you had another idea for this but I don't remember what it was.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (28bc599) to head (0563922).
Report is 526 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #9434      +/-   ##
==========================================
+ Coverage   89.82%   90.85%   +1.02%     
==========================================
  Files         412      415       +3     
  Lines       11878    12969    +1091     
  Branches     2364     2510     +146     
==========================================
+ Hits        10670    11783    +1113     
+ Misses        681      619      -62     
- Partials      527      567      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ScarletKuro]

@ScarletKuro I think you had another idea for this but I don't remember what it was.

just make BaseTypography abstract, then it will give a compiler error when new unspecified type is used.

[danielchalmers]

@jperson2000 What do you think about this remark?

[ScarletKuro]

Can we also rename this pls:

MudBlazor/src/MudBlazor/Themes/Models/Typography.cs

Line 133 in b614357

public class Default : BaseTypography

from Default to DefaultTypography.

The problem I'm facing is that I want to use JSON source generator in ThemeManager as the deepclone fails when trimming / aot used. But I can't use sourcegen as the generator fails on this part because the class and property have the same name :/ the sourgen nests the classes inside.

[ScarletKuro]

Wondering if we should just add ICloneable to whole MudTheme considering that it's very logical to have it deep clonable and it would be faster than STJ source-generator. The only problem is it's easy to forget to add new property to the Clone method.

[ScarletKuro]

Added to v8.0.0 Migration Guide #9953

[danielchalmers]

@ScarletKuro If Default became DefaultTypography, should the others gain this suffix? H3 -> H3Typography

[ScarletKuro]

@ScarletKuro If Default became DefaultTypography, should the others gain this suffix? H3 -> H3Typography

That makes sense to me. It feels odd to have common names like Default, Button, Input etc under the root (MudBlazor namespace), as there’s a good chance of conflicts.
However, I’ll leave that decision up to @henon. I wouldn’t want to do too many renamings here and there.

I only renamed Default because it broke the STJ source generator for some reason(not for the first time I'm seeing this problem). I'm not sure why. My initial thought was that the source generator creates nested code like this:

public class Generated
{
    public Default Default { get; set; } = new();

    public class Default {}
}

This would throw an exception in C#, but it doesn’t for other classes like H1, H2, etc. So only the necessary part was renamed and I couldn’t find a better name than DefaultTypography, since Typography was already taken.

[ScarletKuro]

@ebendorland it's not part of v7.9.0, it's for next major version.