Skip to content

Add GitHub Actions workflow for deploying PR previews#125

Merged
mahesh-panchal merged 3 commits intomainfrom
pr-preview
Oct 9, 2025
Merged

Add GitHub Actions workflow for deploying PR previews#125
mahesh-panchal merged 3 commits intomainfrom
pr-preview

Conversation

@jwindhager
Copy link
Member

This PR adds a GHA workflow for automatically deploying PR previews using https://github.com/marketplace/actions/deploy-pr-preview

@jwindhager jwindhager self-assigned this Oct 9, 2025
@jwindhager jwindhager added the enhancement New feature or request label Oct 9, 2025
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-10-09 11:18 UTC

@mahesh-panchal
Copy link
Collaborator

Is this publishing the preview to the gh-pages branch? That's currently where the site is hosted from, so wouldn't that mean the public would always see the latest preview?

@jwindhager
Copy link
Member Author

jwindhager commented Oct 9, 2025

Yes, it is, but to the pr-preview path (see #125 (comment), for example). Still public, but not linked from the root deployment. The Training-Tech-shorts repo is public, so I personally wouldn't see an issue with that.

@mahesh-panchal
Copy link
Collaborator

The action says it doesn't work from forks. Is there a solution for that?

@jwindhager
Copy link
Member Author

Yes, I mentioned this limitation in #123 (comment). There is no solution as of now, as far as I can tell, but they are working on it. IMO, still an improvement to have this. If people want to use this feature, they need to work in the repo; PRs from forks still work, just without the preview feature then.

@jwindhager jwindhager removed their assignment Oct 9, 2025
Copy link
Collaborator

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. It's better to have some preview if possible. Since it's in a subdirectory that's better. I was under the initial impression that it the latest preview might end up being the actual site, but that's not the case.

I'll squash merge this.

@mahesh-panchal mahesh-panchal merged commit d65ba04 into main Oct 9, 2025
1 check passed
@mahesh-panchal mahesh-panchal deleted the pr-preview branch October 9, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants