Corrections to cell-averaged density computation#213
Merged
Conversation
Update to GFDL master
Brankart
merge Brankart
…parameterization.
…an deterministic) Stanley SGS T variance parameterization.
…ern in MOM_PressureForce_FV, when deterministic parameterization is on.
Add stochastic component to MOM_thickness_diffuse
fix array size declaration and post_data
…chastic) is switched on in PGF and thickness diffusion codes
…leanup (#19) * Test Stanley EOS param in mixed_layer_restrat * Fix size of TS cov, S var in Stanley calculate_density calls * Test move stanley scheme initialization * Added missing openMP directives * Revert Stanley tvar discretization (#18) * Perform vertical filling in calculation of T variance * Variable declaration syntax error, remove scaling from get_param * Fix call to vert_fill_TS * Code cleanup, whitespace cleanup Co-authored-by: Jessica Kenigson <jessicak@cheyenne1.cheyenne.ucar.edu>
Use Stanley (2020) variance; scheme off at coast
Change start indices in stanley_density_1d
Stanley param in MOM_isopycnal_slopes and thickness diffuse index fix
Pull in Jessica's isopycnal slope code
Collaborator
|
Passing tests in mom_aux and Cheyenne-MOM6-examples. MOM_input parameters added: MOM_input parameters there were removed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on mom-ocean#1156 and mom-ocean#1209, implementing a correction to the computation of cell-averaged density in various parts of the model. A description of the parameterization and results can be found in these papers.
The main updates in this PR are the ability to use a new stochastic version of the correction, and the ability to turn on the density correction in the calculation of the mixed layer lateral density gradient in the mixed layer restratification parameterization.
In addition, the code related to this parameterization has been re-factored a bit, along with some small bug fixes.
The parameterization can be toggled on/off in different parts of the code using the following flags:
USE_STANLEY_PGFturns it on in computation of the pressure gradient forceUSE_STANLEY_MLturns it on in the mixed layer restratification parameterizationUSE_STANLEY_ISOturns it on in the computation of isopycnal slopes in MOM_isopycnal_slopes.F90. This doesn't necessarily turn it on in MOM_thickness_diffuse.F90 though, since MOM_thickness_diffuse.F90 sometimes computes its own isopycnal slopes. See belowUSE_STANLEY_GMturns it on in the computation of isopycnal slopes in GM. Specifically, it setsuse_stanleyto.TRUE.in these lines of MOM_thickness_diffuse.F90MOM6/src/parameterizations/lateral/MOM_thickness_diffuse.F90
Lines 797 to 798 in 3d62428
The tunable coefficients of the parameterization are controlled by
STANLEY_COEFFthis is the main tunable coefficient, denoted c in the papers linked above. The SGS temperature variance is parameterized as c times squared temperature differences.STANLEY_Aallows you to tune the amplitude of the noise in the stochastic version. The multiplicative noise isexp(a * chi). With a default of1.0you get the stochastic parameterization described in the papers. With a value of0.0you get a deterministic parameterization.