Merged
Conversation
(jt): gt, shouldn't we convert this to a property of the class?This comment was generated by todo based on a
|
jonasteuwen
approved these changes
Sep 2, 2021
Contributor
jonasteuwen
left a comment
jonasteuwen
left a comment
There was a problem hiding this comment.
It is slightly uncomfortable that pylint fails, but the errors do not seem to have any significant meaning and the code runs as expected. Pylint should be fixed at a later stage, but this commit is important for now.
georgeyiasemis
added a commit
that referenced
this pull request
Sep 2, 2021
Fix evaluate function (#111)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed evaluate function as it did not use last slice of last volume to compute volume and target for validation metrics when is_validation_process = True.