Skip to content

Merge MRIReconstruction with RIM #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonasteuwen merged 5 commits into from
Sep 3, 2021
Merged

Merge MRIReconstruction with RIM #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c891333
Merge pull request #112 from directgroup/main
georgeyiasemis Sep 2, 2021
28f2871
Merged RIM with MRIReconstruction models
georgeyiasemis Sep 2, 2021
28b9fd0
Removed unnecessary arg
georgeyiasemis Sep 3, 2021
13a4a5e
Local variables made class attrs
georgeyiasemis Sep 3, 2021
009ec9b
Code quality and documentation
georgeyiasemis Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions direct/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

import direct.utils.logging
from direct.config.defaults import DefaultConfig, InferenceConfig, TrainingConfig, ValidationConfig
from direct.nn.rim.mri_models import MRIReconstruction
from direct.utils import communication, count_parameters, str_to_class

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -131,9 +130,11 @@ def initialize_models_from_config(cfg, models, forward_operator, backward_operat
curr_model_cfg = {kk: vv for kk, vv in v.items() if kk != "model_name"}
additional_models[k] = curr_model(**curr_model_cfg)

# MODEL SHOULD LOAD MRI RECONSTRUCTION INSTEAD AND USE A FUNCTOOLS PARTIAL TO PASS THE OPERATORS
# the_real_model = models["model"](**{k: v for k, v in cfg.model.items() if k != "model_name"})
model = MRIReconstruction(models["model"], forward_operator, backward_operator, 2, **cfg.model).to(device)
model = models["model"](
forward_operator=forward_operator,
backward_operator=backward_operator,
**{k: v for (k, v) in cfg.model.items()},
).to(device)

# Log total number of parameters
count_parameters({"model": model, **additional_models})
Expand Down
334 changes: 0 additions & 334 deletions direct/nn/rim/mri_models.py
View file
Open in desktop

This file was deleted.

Loading