Conversation
Implement varnet
github-actions
bot
added
documentation
|
This is addressing #116. Can you look into pylint? |
jonasteuwen
left a comment
jonasteuwen
left a comment
There was a problem hiding this comment.
Some initial comments.
| assert_complex(coil_data, complex_last=True) | ||
| assert_complex(sensitivity_map, complex_last=True) |
There was a problem hiding this comment.
Is this assert_complex still needed? Can't our internal representation completely switch to complex tensors, and use .is_complex() or so (that can be done in the assert_complex of course)?
There was a problem hiding this comment.
This will require to change the whole software & models so let's keep this as a future change
| # 2D data is batched and contains keys: | ||
| # "filename_slice", "slice_no" | ||
| # "sampling_mask" of shape: (batch, 1, height, width, 1) | ||
| # "sensitivity_map" of shape: (batch, coil, height, width, complex=2) | ||
| # "target" of shape: (batch, height, width) | ||
| # "masked_kspace" of shape: (batch, coil, height, width, complex=2) | ||
|
|
There was a problem hiding this comment.
It feels we should write this down somewhere. Maybe in the documentation?
There was a problem hiding this comment.
Documentation of engine?
Rebase from main
…t into implement-recon-models
jonasteuwen
left a comment
jonasteuwen
left a comment
There was a problem hiding this comment.
LGTM. We need some small changes for v0.3, but good for now.
2 participants
Reconstruction Models added:
Additional models added: