Skip to content

Added possibility to initialize from a configuration file#141

Merged
jonasteuwen merged 6 commits intomainfrom
load-checkpoint-from-config
Dec 16, 2021
Merged

Added possibility to initialize from a configuration file#141
jonasteuwen merged 6 commits intomainfrom
load-checkpoint-from-config

Conversation

@jonasteuwen
Copy link
Copy Markdown
Contributor

Add the ability to start from a checkpoint.

@georgeyiasemis Let me know if this would be wanted/unwanted behaviour. I am not so much in favour of allowing command line argument overwrite config variables because it makes it not reproducible.

@georgeyiasemis
Copy link
Copy Markdown
Contributor

Add the ability to start from a checkpoint.

@georgeyiasemis Let me know if this would be wanted/unwanted behaviour. I am not so much in favour of allowing command line argument overwrite config variables because it makes it not reproducible.

Good! I think it's ok if we are throwing a warning.

georgeyiasemis
georgeyiasemis previously approved these changes Dec 13, 2021
@georgeyiasemis georgeyiasemis self-requested a review December 13, 2021 22:22
@georgeyiasemis georgeyiasemis dismissed their stale review December 13, 2021 22:24

Need to review again

@jonasteuwen jonasteuwen merged commit c171840 into main Dec 16, 2021
@jonasteuwen jonasteuwen deleted the load-checkpoint-from-config branch December 16, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants