Skip to content

Adds CIRIM#156

Merged
georgeyiasemis merged 18 commits intoNKI-AI:mainfrom
wdika:cirim
Jul 22, 2022
Merged

Adds CIRIM#156
georgeyiasemis merged 18 commits intoNKI-AI:mainfrom
wdika:cirim

Conversation

@wdika
Copy link
Copy Markdown
Contributor

@wdika wdika commented Dec 22, 2021

This pr adds the Cascades of Independently Recurrent Inference Machines (CIRIM), as presented in "Karkalousos, D. et al. (2021) ‘Assessment of Data Consistency through Cascades of Independently Recurrent Inference Machines for fast and robust accelerated MRI reconstruction’. Available at: https://arxiv.org/abs/2111.15498v1".

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #156 (ca75ee1) into main (9e84f46) will increase coverage by 0.48%.
The diff coverage is 97.50%.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   80.80%   81.29%   +0.48%     
==========================================
  Files          72       74       +2     
  Lines        5320     5480     +160     
==========================================
+ Hits         4299     4455     +156     
- Misses       1021     1025       +4     
Impacted Files Coverage Δ
direct/nn/cirim/cirim_engine.py 95.45% <95.45%> (ø)
direct/nn/cirim/cirim.py 98.27% <98.27%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e84f46...ca75ee1. Read the comment docs.

@jonasteuwen
Copy link
Copy Markdown
Contributor

@wdika Can you rebase from main?

wdika and others added 6 commits January 10, 2022 10:54
* Reduce pylint warnings
* Reduce pyflakes warnings
* Add codacy code quality badge
* Improving code quality by renaming variables
* Bump version: 1.0.0 → 1.0.1-dev0
* Do not run codecov/patch
Co-authored-by: wdika <dimitriskarkalousos@gmail.com>
@wdika
Copy link
Copy Markdown
Contributor Author

wdika commented Jan 10, 2022

@wdika Can you rebase from main?

@jonasteuwen I rebased.

  • The PR Labeler error is still here, due to privacy restrictions (?).
  • Errors from codacy keep some kind of consistency on the repo, as they are the same on the other models and models' engines scripts. Not sure if I should fix them individually or that would go on a future request and a general refactoring for all models?

Copy link
Copy Markdown
Contributor

@georgeyiasemis georgeyiasemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

wdika added 5 commits April 4, 2022 14:22
# Conflicts:
#	direct/__init__.py
#	direct/data/datasets.py
#	direct/data/lr_scheduler.py
#	direct/data/mri_transforms.py
#	direct/data/transforms.py
#	direct/engine.py
#	direct/functionals/psnr.py
#	direct/nn/didn/didn.py
#	direct/nn/unet/unet_2d.py
#	direct/utils/io.py
#	docker/README.md
#	docs/model_zoo.rst
#	setup.cfg
@wdika wdika requested a review from georgeyiasemis April 11, 2022 14:08
@georgeyiasemis
Copy link
Copy Markdown
Contributor

@wdika Can you pull from main please? Black is failing because there is a new version

@wdika
Copy link
Copy Markdown
Contributor Author

wdika commented Apr 12, 2022

@wdika Can you pull from main please? Black is failing because there is a new version

Thanks @georgeyiasemis! I had to update Black, which now passes successfully.

@georgeyiasemis
Copy link
Copy Markdown
Contributor

@wdika Codacy also complains about some issues: https://app.codacy.com/gh/NKI-AI/direct/pullRequest?prid=8627324

Can you take a look please?

@wdika
Copy link
Copy Markdown
Contributor Author

wdika commented Apr 22, 2022

@wdika Codacy also complains about some issues: https://app.codacy.com/gh/NKI-AI/direct/pullRequest?prid=8627324

Can you take a look please?

@georgeyiasemis thanks for the reply, I fixed the unused imports and variables errors. However, there are still four left about "Line too long" and "Too many local variables".

After checking the files of the rest implemented models I saw that those are common errors. So, could you please let me know if this would pass the standards now?

@wdika wdika marked this pull request as ready for review April 22, 2022 09:29
@jonasteuwen
Copy link
Copy Markdown
Contributor

@wdika Can you please rebase from main and make sure all tests pass?

@wdika
Copy link
Copy Markdown
Contributor Author

wdika commented Jun 1, 2022

@wdika Can you please rebase from main and make sure all tests pass?

@jonasteuwen I rebased from main.

Still, the PR Labeler doesn't pass because of access restrictions. Codacy also complains but I guess those are in general "errors" of direct. Such as the "Line too long" when citing a paper and "Too many local variables" in the forward func of the model engine. As I see compared to the rest implementations those errors are present there as well.

Not sure if I need to change something there.

@georgeyiasemis georgeyiasemis merged commit f4189f2 into NKI-AI:main Jul 22, 2022
georgeyiasemis pushed a commit that referenced this pull request Jul 31, 2022
* Adds CIRIM

Co-authored-by: wdika <dimitriskarkalousos@gmail.com>
georgeyiasemis pushed a commit that referenced this pull request Jul 31, 2022
* Adds CIRIM

Co-authored-by: wdika <dimitriskarkalousos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants