Merged
Conversation
github-actions
bot
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 74.39% 74.63% +0.23%
==========================================
Files 70 71 +1
Lines 6300 6111 -189
==========================================
- Hits 4687 4561 -126
+ Misses 1613 1550 -63
Continue to review full report at Codecov.
|
jonasteuwen
approved these changes
Jan 19, 2022
Comment on lines
+8
to
+11
| disable: | ||
| - E501 | ||
| - W605 | ||
|
|
.prospector.yml
Outdated
Comment on lines
+14
to
+15
| - W | ||
| - import-outside-toplevel |
Contributor
There was a problem hiding this comment.
Not sure we should do this.
jonasteuwen
added a commit
that referenced
this pull request
Feb 10, 2022
* Improve code quality (#158, #166) * Reduce pylint warnings * Reduce pyflakes warnings * Add codacy code quality badge * Improving code quality by renaming variables * Bump version: 1.0.0 → 1.0.1-dev0 * Adds citation button (#169) Co-authored-by: wdika <dimitriskarkalousos@gmail.com> * Update model_zoo.rst * Fix linter errors (#170) * Fix some linter warnings * Add .prospector.yml * Update docs/index.rst * Delete README.md * Update README.rst * Merged MRI models engine to MRIModelEngine * Minor fix * Func to get size of objiect * - Fix typo - Refactor to have functions not class members * - Remove process_output from base class * First attempt to rewriting validation process (will not pass CI) * Rewrite validation process (will not pass CI) * Improve validation * Improve validation * Log metric output * Improve metric log output * Replace ISMRMD with xml parser * Make sure the metric is cloned * Refactoring * Refactoring * Refactoring * Fix roll test * Remove `is_validation_process` * Move ismrmrd dependency to dev dependencies * Install extras for tox * Make compatible tests for new updates * Minor fix * Fix pytest warning * Fix pylint errors * Update black.yml * Update black.yml * Update black.yml * Black 22.1.0 fixes * Black 22.1.0 fixes * Updated docs, fixed `write_output_to_h5` to work with new predict function * Update `utils` * Add test * Update rim_engine.py * Minor fix * Disable tensorboard warnings * Remove whitespace * Update train.py * Update varnet_engine.py * Test engine.train * Test engine.train * Refine test * Fix typo and unused import * Add crop option for inference * Codacy pseudonumber complains * Update setup.py `h5py 3.6.0` caused memory leak * Minor documentation fix * Update writers.py * Update mri_models.py * Edit `set_all_seeds` * Update subsample.py * Minor fix * Fix/supress codacy warnings * Fix/supress codacy warnings * Fix/supress codacy warnings * Lazy formatting * Lazy formatting Co-authored-by: Jonas Teuwen <2347927+jonasteuwen@users.noreply.github.com> Co-authored-by: Dimitris Karkalousos <d.karkalousos@amsterdamumc.nl> Co-authored-by: wdika <dimitriskarkalousos@gmail.com> Co-authored-by: Jonas Teuwen <j.teuwen@nki.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed some linter errors:
docformattercompute_resolution,compute_model_per_coil,..) now independent functions innn/utilsto avoid dublication.prospector.yamlfile to filter codacy checks