Skip to content

Normalised convgru#176

Merged
georgeyiasemis merged 11 commits intomainfrom
normalised-convgru
Mar 14, 2022
Merged

Normalised convgru#176
georgeyiasemis merged 11 commits intomainfrom
normalised-convgru

Conversation

@georgeyiasemis
Copy link
Copy Markdown
Contributor

Add Normalised conv GRU option for RecurrentVarNet and RIM.

Update mri_transforms.py
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2022

Codecov Report

Merging #176 (d39bdbc) into main (70ac248) will decrease coverage by 0.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   76.18%   75.76%   -0.43%     
==========================================
  Files          71       71              
  Lines        5237     5120     -117     
==========================================
- Hits         3990     3879     -111     
+ Misses       1247     1241       -6     
Impacted Files Coverage Δ
direct/nn/recurrent/recurrent.py 100.00% <100.00%> (ø)
direct/nn/recurrentvarnet/recurrentvarnet.py 91.75% <100.00%> (-1.06%) ⬇️
direct/nn/rim/rim.py 91.79% <100.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ac248...d39bdbc. Read the comment docs.

@georgeyiasemis georgeyiasemis removed the request for review from jonasteuwen March 12, 2022 19:37
Copy link
Copy Markdown
Contributor Author

@georgeyiasemis georgeyiasemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@georgeyiasemis georgeyiasemis merged commit 5497e07 into main Mar 14, 2022
@georgeyiasemis georgeyiasemis deleted the normalised-convgru branch March 14, 2022 16:13
georgeyiasemis added a commit that referenced this pull request Mar 30, 2022
georgeyiasemis added a commit that referenced this pull request Mar 30, 2022
georgeyiasemis added a commit that referenced this pull request Apr 4, 2022
* Update mri_transforms.py

`torch.kthvalue` returns error when k=0 (give 0th value). 0 should be replaced by 1 (1st value). 
This was not caused by old `torch` versions (<1.11.0).

* Normalised convgru (#176)

* Add NormConv2dGRU
* Option for NormConv2dGRU for RIM/RecurrentVarNet
* Add tests

* Update documentation (#183)

Minor documentation updates:
* Fix broken link in installation.rst
* docker/README.md -> /README.rst
georgeyiasemis added a commit that referenced this pull request Apr 4, 2022
* Add NormConv2dGRU
* Option for NormConv2dGRU for RIM/RecurrentVarNet
* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant