Remove unambiguous complex assertions (#194)#195
Merged
georgeyiasemis merged 1 commit intocode-qualityfrom Apr 8, 2022
Merged
Conversation
* `assert_complex(shape, complex_last)` --> `assert_complex(shape, complex_axis, complex_last=None)` * `modulus_if_complex` removed * `modulus` need to specify axis * `MRIModelEngine` cropper expect the modulus of predicted data
jonasteuwen
pushed a commit
that referenced
this pull request
Apr 19, 2022
* Remove unambiguous complex assertions (#194) (#195) * Improve typing * `modulus_if_complex` removed, `modulus` needs to specify axis. * `modulus` need to specify axis * Improve documentation and `README.rst` * Added tests * Add end-to-end tests * Several bug fixes Co-authored-by: George Yiasemis <georgeyiasemis.hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert_complex(shape, complex_last)-->assert_complex(shape, complex_axis, complex_last=None)modulus_if_complexremovedmodulusneed to specify axisMRIModelEnginecropper expect the modulus of predicted data