Merged
Conversation
… with **kwargs, training_root and validation_root not required now for train - some datasets don't require saved data.
…to allow for file filtering, minor fixes
github-actions
bot
added
documentation
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 80.69% 80.79% +0.10%
==========================================
Files 71 72 +1
Lines 5096 5317 +221
==========================================
+ Hits 4112 4296 +184
- Misses 984 1021 +37
Continue to review full report at Codecov.
|
2 tasks
jonasteuwen
reviewed
May 11, 2022
Contributor
jonasteuwen
left a comment
jonasteuwen
left a comment
There was a problem hiding this comment.
Looks good to me, but please add references where possible, e.g. in simulating a sensitivity map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
direct train,direct predictandpython3 projects/predict_val.pyto not necessarily require path to data as some datasets don't require it -build_dataset_from_inputrelies on**kwargsnow