Skip to content

Implement Gaussian masks#230

Merged
jonasteuwen merged 10 commits intomainfrom
gaussian-sampling
Nov 4, 2022
Merged

Implement Gaussian masks#230
jonasteuwen merged 10 commits intomainfrom
gaussian-sampling

Conversation

@georgeyiasemis
Copy link
Copy Markdown
Contributor

@georgeyiasemis georgeyiasemis commented Nov 1, 2022

  • Implements 1D Cartesian Gaussian (Gaussian1DMaskFunc) and 2D Gaussian (Gaussian2DMaskFunc) mask functions.
  • Minor documentation improvements/additions
  • Added tests

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 1, 2022

Codecov Report

Base: 82.92% // Head: 83.55% // Increases project coverage by +0.63% 🎉

Coverage data is based on head (90fc899) compared to base (e7ea67e).
Patch coverage: 94.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   82.92%   83.55%   +0.62%     
==========================================
  Files          88       88              
  Lines        5967     6001      +34     
==========================================
+ Hits         4948     5014      +66     
+ Misses       1019      987      -32     
Impacted Files Coverage Δ
direct/data/transforms.py 96.31% <ø> (ø)
direct/nn/cirim/cirim.py 98.27% <ø> (ø)
direct/nn/recurrentvarnet/recurrentvarnet.py 91.83% <ø> (ø)
direct/nn/varnet/varnet.py 94.44% <ø> (ø)
direct/common/subsample.py 94.45% <94.23%> (+9.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasteuwen jonasteuwen merged commit 5bda5c5 into main Nov 4, 2022
@jonasteuwen jonasteuwen deleted the gaussian-sampling branch November 4, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants