Skip to content

Adds 3D vSHARP model#273

Merged
jonasteuwen merged 10 commits intomainfrom
feature/vsharp-3d
Apr 2, 2024
Merged

Adds 3D vSHARP model#273
jonasteuwen merged 10 commits intomainfrom
feature/vsharp-3d

Conversation

@georgeyiasemis
Copy link
Copy Markdown
Contributor

@georgeyiasemis georgeyiasemis self-assigned this Mar 28, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 84.76%. Comparing base (b660012) to head (725a119).

Files Patch % Lines
direct/nn/vsharp/vsharp.py 94.59% 4 Missing ⚠️
direct/nn/unet/unet_3d.py 98.33% 2 Missing ⚠️
direct/nn/unet/unet_2d.py 75.00% 1 Missing ⚠️
direct/nn/vsharp/vsharp_engine.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   84.05%   84.76%   +0.70%     
==========================================
  Files          95       96       +1     
  Lines        6742     6963     +221     
==========================================
+ Hits         5667     5902     +235     
+ Misses       1075     1061      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks, mostly about documentation and variable choice and typing

@jonasteuwen jonasteuwen merged commit 4355037 into main Apr 2, 2024
@jonasteuwen jonasteuwen deleted the feature/vsharp-3d branch April 2, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants