Fix unbound-control stdin commands for multi-process Unbounds#1069
Merged
Fix unbound-control stdin commands for multi-process Unbounds#1069
Conversation
operation (local_zones_remove, local_zones, local_datas_remove, local_datas, view_local_datas_remove, view_local_datas). They will be properly distributed to all processes. dump_cache and load_cache are no longer supported in multi-process operation.
now checks both single and multi process/thread operation.
wcawijngaards
approved these changes
May 17, 2024
Member
wcawijngaards
left a comment
wcawijngaards
left a comment
There was a problem hiding this comment.
This looks like it would fix consistency for config changes, by distributing the content to the worker processes. The code looks fine.
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
gthess
added a commit
that referenced
this pull request
May 17, 2024
- Merge #1069: Fix unbound-control stdin commands for multi-process Unbounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR distributes commands that read stdin properly to other processes. These are
local_zones_remove,local_zones,local_datas_remove,local_datas,view_local_datas_removeandview_local_datas.testdata/09-unbound-control.tdiris updated to check the correctness on different scenarios. It now does it one line at a time but it can be updated to put several lines in the same distribute batch.dump_cacheandload_cacheare no longer supported in multi-process operation because of confusing results in that scenario.testdata/remote-threaded.tdiris removed as it is obsoleted by the updatedtestdata/09-unbound-control.tdir.