Skip to content

UseNLog allow fallback to only EnvironmentName for NLog config#773

Merged
snakefoot merged 1 commit intoNLog:masterfrom
snakefoot:master
Nov 21, 2024
Merged

UseNLog allow fallback to only EnvironmentName for NLog config#773
snakefoot merged 1 commit intoNLog:masterfrom
snakefoot:master

Conversation

@snakefoot
Copy link
Copy Markdown
Contributor

@snakefoot snakefoot commented Nov 20, 2024

Use LoadConfigurationFromFile instead of explicit creating XmlLoggingConfiguration for better NLog InternalLogger output.

@snakefoot snakefoot changed the title UseNLog fallback to only EnvironmentName when loading NLog config UseNLog allow fallback to only EnvironmentName when loading NLog config Nov 20, 2024
@snakefoot snakefoot changed the title UseNLog allow fallback to only EnvironmentName when loading NLog config UseNLog allow fallback to only EnvironmentName for NLog config Nov 20, 2024
@snakefoot snakefoot closed this Nov 20, 2024
@snakefoot snakefoot reopened this Nov 20, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.88235% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (95932f4) to head (9dca19d).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...tensions.Hosting/Extensions/ConfigureExtensions.cs 55.88% 5 Missing and 10 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   81.47%   81.01%   -0.46%     
==========================================
  Files          19       19              
  Lines        1808     1817       +9     
  Branches      321      320       -1     
==========================================
- Hits         1473     1472       -1     
- Misses        193      198       +5     
- Partials      142      147       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants