Skip to content

FileTarget - SetCreationTimeUtc only when IsArchivingEnabled#5382

Merged
snakefoot merged 1 commit intoNLog:devfrom
snakefoot:fix-UpdateCreationTime
Oct 24, 2023
Merged

FileTarget - SetCreationTimeUtc only when IsArchivingEnabled#5382
snakefoot merged 1 commit intoNLog:devfrom
snakefoot:fix-UpdateCreationTime

Conversation

@snakefoot
Copy link
Copy Markdown
Contributor

@snakefoot snakefoot commented Oct 24, 2023

Followup to #5381 (Only apply fix for Windows FileSystem Tunnelling when IsArchivingEnabled = true where NLog depends on File.CreationTimeUtc)

Avoid overhead from calling exotic file-api-methods, that might not be supported on limited-platforms (unless using exotic NLog FileTarget features). See also: #1100 and #1125

@snakefoot snakefoot added enhancement Improvement on existing feature file-target labels Oct 24, 2023
@snakefoot snakefoot enabled auto-merge (squash) October 24, 2023 21:50
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit 3f78efd into NLog:dev Oct 24, 2023
@snakefoot snakefoot added this to the 5.2.6 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement on existing feature file-target size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant