Merged
Conversation
merge dev/emc
merge dev/emc
merge to latest dev/emc
JessicaMeixner-NOAA
approved these changes
Apr 9, 2020
Collaborator
JessicaMeixner-NOAA
left a comment
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
I trust that you ran some regression tests and they passed. This definitely cleans things up! Thanks!
jiandewang
approved these changes
Apr 9, 2020
Collaborator
jiandewang
left a comment
jiandewang
left a comment
There was a problem hiding this comment.
the newly defined function chkerr makes code much clean and easy to read, approve this PR.
DeniseWorthen
added a commit
to DeniseWorthen/MOM6
that referenced
this pull request
Apr 9, 2020
Feature/logcleanup (NOAA-EMC#20)
Collaborator
Author
|
@jiandewang would you go ahead and update MOM6-interface too? Thx. |
Collaborator
|
Ok will do
On Thu, Apr 9, 2020 at 11:56 AM Denise Worthen ***@***.***> wrote:
@jiandewang <https://github.com/jiandewang> would you go ahead and update
MOM6-interface too? Thx.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMGAS4CDMWFBJTGXPQGJRDRLXVZDANCNFSM4MEU62XQ>
.
--
Jiande Wang
IMSG at NOAA/NWS/NCEP/EMC
cubic 2088
jiande.wang@noaa.gov
phone:3016833725
|
jiandewang
pushed a commit
to jiandewang/MOM6
that referenced
this pull request
Jun 17, 2021
merge in latest dev/gfdl changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #19
This PR is only for cleanup of error message handling in the nuopc_driver to improve code readability and reduce code length.
Regression test was run for cold and 1d benchmark cases. Full regression test suite was not run due to abnormally high Hera queue congestion.
Log report: rtreport.txt